Fix filtering with negated labels#28455
Draft
simonbrauner wants to merge 1 commit intocontainers:mainfrom
Draft
Conversation
Signed-off-by: Šimon Brauner <sbrauner@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?
While working on #28413, I found out that when filtering based on labels, the
labelfilters are combined with AND, whilelabel!filters are combined with OR. I thought it would make more sense to handle both labels with the same operation, as it would be unexpected otherwise, and the way it looks in the codereturn !filters.MatchLabelFilters(filterValues, v.Labels())makes it seem like a bug.Currently, for podman this works correctly in
images, and incorrectly forcontainers,volumes, andpods.This is a breaking change and it may make podman more inconsistent with docker.
It looks like for docker,
label!has the same problem involume prune, so I reported it docker/cli#6918.